Skip to content

[rust] Fallback for chromedriver versions in Selenium Manager (#11383)#11454

Merged
titusfortner merged 1 commit intotrunkfrom
se_mgr_fallback
Jan 7, 2023
Merged

[rust] Fallback for chromedriver versions in Selenium Manager (#11383)#11454
titusfortner merged 1 commit intotrunkfrom
se_mgr_fallback

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

@bonigarcia bonigarcia commented Dec 20, 2022

Description

This PR implements a fallback mechanism (max 5 retries) when reading the versions of chromedriver. For instance:

> cargo run -- --browser chrome --browser-version dev
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s
     Running `target\debug\selenium-manager.exe --browser chrome --browser-version dev`
WARN    Error getting version of chromedriver 110. Retrying with chromedriver 109 (attempt 1/5)
INFO    C:\Users\boni\.cache\selenium\chromedriver\win32\109.0.5414.25\chromedriver.exe

> cargo run -- --browser chrome --browser-version canary
    Finished dev [unoptimized + debuginfo] target(s) in 0.20s
     Running `target\debug\selenium-manager.exe --browser chrome --browser-version canary`
WARN    Error getting version of chromedriver 111. Retrying with chromedriver 110 (attempt 1/5)
WARN    Error getting version of chromedriver 110. Retrying with chromedriver 109 (attempt 2/5)
INFO    C:\Users\boni\.cache\selenium\chromedriver\win32\109.0.5414.25\chromedriver.exe

Motivation and Context

This PR solves #11383.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Copy Markdown
Member

titusfortner commented Dec 20, 2022

Hmm, I think there should just be one or two fallbacks instead of 5? The specific problem at hand is that it looks like Chrome only releases drivers for production and beta, and not for dev and canary, so we should use the beta version of the driver for dev, and theoretically we figure out how to get the most recent nightly build of the driver for Canary. Microsoft makes everything much easier for Edge, and this isn't an issue for Firefox or Safari.

@bonigarcia
Copy link
Copy Markdown
Member Author

bonigarcia commented Dec 21, 2022

@titusfortner Having a retries count of 5 for this logic is not too much, IMO.
See, for example, the provided example for the canary version. In that case, the proper driver version is achieved on the third attempt since the browser version was 111, but chromedriver 111 is not published (first try), nor chromedriver 110 (second try), and the latest published version is 109 (third and final try, in that case).

All in all, the minimum retries number should be three. And having a guard of two more tries, just in case, does not hurt, IMO.

@titusfortner titusfortner merged commit 7d5fff9 into trunk Jan 7, 2023
@titusfortner titusfortner deleted the se_mgr_fallback branch January 7, 2023 14:23
@bonigarcia bonigarcia mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bonigarcia @titusfortner