[rust] Reuse common http client in Selenium Manager#11449
Merged
bonigarcia merged 3 commits intotrunkfrom Jan 10, 2023
Merged
Conversation
bonigarcia
force-pushed
the
se_mgr_http_client
branch
2 times, most recently
from
9c6f148 to
f969e78
Compare
bonigarcia
force-pushed
the
se_mgr_http_client
branch
from
5cc8352 to
f1a6896
Compare
diemol
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a shared instance of the HTTP client used in the Rust logic of Selenium Manager, using
rusttlsinstead of native TLS (to prevent #11291), and accepting self-signed certificates (to prevent #11406).Motivation and Context
This PR will prevent issues like #11406 in the upcoming releases of Selenium Manager. Moreover, the shared HTTP client will be helpful in Selenium Manager M3 (e.g., for proxy setup).
Types of changes
Checklist