[java][cdp] Ensure console events return args as it is#11435
Merged
pujagani merged 1 commit intoSeleniumHQ:trunkfrom Dec 16, 2022
Merged
[java][cdp] Ensure console events return args as it is#11435pujagani merged 1 commit intoSeleniumHQ:trunkfrom
pujagani merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Codecov ReportBase: 52.83% // Head: 54.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## trunk #11435 +/- ##
==========================================
+ Coverage 52.83% 54.54% +1.70%
==========================================
Files 82 85 +3
Lines 5551 5627 +76
Branches 198 243 +45
==========================================
+ Hits 2933 3069 +136
+ Misses 2420 2315 -105
- Partials 198 243 +45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11377
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Ensure console events return args as it is.
Selenium was modifying the args and returning them to the user. That resulted in wrong values, the PR fixes that.
Motivation and Context
See #11377.
Types of changes
Checklist