Skip to content

[rust] Use optional arguments for CLI parsing in Selenium Manager#11421

Merged
bonigarcia merged 1 commit intotrunkfrom
se_mgr_optional_params
Dec 13, 2022
Merged

[rust] Use optional arguments for CLI parsing in Selenium Manager#11421
bonigarcia merged 1 commit intotrunkfrom
se_mgr_optional_params

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

Description

This PR improves the way in which optional parameters (e.g., browser-version or driver-version) are handled in the Rust logic of Selenium Manager.

Motivation and Context

This PR is a preparation for #11365.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia merged commit 19ffbef into trunk Dec 13, 2022
@bonigarcia bonigarcia deleted the se_mgr_optional_params branch December 13, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants