[java] change chromium service names from whitelisted to allowed by titusfortner · Pull Request #11409 · SeleniumHQ/selenium

titusfortner · 2022-12-10T20:22:04Z

In Chrome v87 Google changed the name of the parameter in the documentation from whitelisted-ips to allowed-ips, but both are still supported under the hood.

EdgeDriverService was already using "allowed" naming convention. This PR changes the ChromeDriverService implementation to match it. The two questions I have:

Do we want to change what we're sending to the driver if it means that it won't be recognized by this Chrome < v87?
How do you communicate the name change of a System property? Marking the public constant as deprecated, doesn't seem very useful. Do we want to raise a warning?

codecov-commenter · 2022-12-10T20:42:38Z

Codecov Report

Base: 54.54% // Head: 54.54% // No change to project coverage 👍

Coverage data is based on head (93e4a12) compared to base (3e146d0).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #11409   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          85       85           
  Lines        5627     5627           
  Branches      243      243           
=======================================
  Hits         3069     3069           
  Misses       2315     2315           
  Partials      243      243

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.