[java] allow Edge to set driver log level as well#11404
[java] allow Edge to set driver log level as well#11404titusfortner wants to merge 1 commit intoSeleniumHQ:trunkfrom
Conversation
titusfortner
force-pushed
the
chromium_opts
branch
from
c328753 to
6869304
Compare
Codecov ReportBase: 53.66% // Head: 53.66% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #11404 +/- ##
=======================================
Coverage 53.66% 53.66%
=======================================
Files 85 85
Lines 5650 5650
Branches 200 200
=======================================
Hits 3032 3032
Misses 2418 2418
Partials 200 200 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
SonarCloud Quality Gate failed. |
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
So far the changes look good. I can check again when it is ready for review.
|
Well, actually, I probably should back up and see if we even want this since it means things behave differently between local and remote. |
|
We decided in TLC meeting we do not want to do this, we want to do the opposite of this. |
3 participants
Chrome allows setting log level in Options class, and consumes it in the Service class.
I want to provide the same functionality to Edge. This PR just deals with moving the things to the super class so that Edge has access to them.
This PR does not wire in the functionality in the Edge Service class. Trying to do this in smaller, easier to parse chunks. Is this the right way to do this?
Marking it as Draft since it can't be used as-is. I have other changes in mind for Service classes if this is ok.