Skip to content

[java] remove deprecated Firefox capabilities and consolidate tests#11403

Merged
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
titusfortner:java_ff
Dec 10, 2022
Merged

[java] remove deprecated Firefox capabilities and consolidate tests#11403
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
titusfortner:java_ff

Conversation

@titusfortner
Copy link
Copy Markdown
Member

@titusfortner titusfortner commented Dec 10, 2022

These 3 capabilities have been throwing the non-w3c deprecation warning since we added it, so they should be ok to remove now

This cleans the code where they was used and removes the relevant tests.
While I was updating tests, I also moved all relevant tests from MarionetteTest to FirefoxTest; there was a lot of duplication.

@titusfortner titusfortner requested a review from diemol December 10, 2022 04:33
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 10, 2022 •
edited
Loading

Codecov Report

Base: 53.66% // Head: 53.66% // No change to project coverage 👍

Coverage data is based on head (b6e3df6) compared to base (b6e3df6).
Patch has no changes to coverable lines.

❗ Current head b6e3df6 differs from pull request most recent head ad2341d. Consider uploading reports for the commit ad2341d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #11403   +/-   ##
=======================================
  Coverage   53.66%   53.66%           
=======================================
  Files          85       85           
  Lines        5650     5650           
  Branches      200      200           
=======================================
  Hits         3032     3032           
  Misses       2418     2418           
  Partials      200      200

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

diemol
diemol approved these changes Dec 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @titusfortner!

I hope I checked everything correctly, I believe all removed methods were either not public or the super class will take over.

I'll wait for CI to finish and then I will merge.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@titusfortner titusfortner merged commit 7627ee8 into SeleniumHQ:trunk Dec 10, 2022
@ollie-iterators ollie-iterators mentioned this pull request Dec 12, 2022
Closed
@titusfortner titusfortner deleted the java_ff branch January 12, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@titusfortner @codecov-commenter @diemol