[rust] Allow Selenium Manager to be used as a Rust lib crate (#11132)#11371
Merged
bonigarcia merged 1 commit intotrunkfrom Dec 9, 2022
Merged
[rust] Allow Selenium Manager to be used as a Rust lib crate (#11132)#11371bonigarcia merged 1 commit intotrunkfrom
bonigarcia merged 1 commit intotrunkfrom
Conversation
bonigarcia
force-pushed
the
se_mgr_lib
branch
from
a3e310a to
077d419
Compare
Merged
8 tasks
bonigarcia
force-pushed
the
se_mgr_lib
branch
2 times, most recently
from
d2a497f to
fe07067
Compare
diemol
previously requested changes
Dec 9, 2022
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
One small comment, everything else looks fine. It is a refactoring in the end.
bonigarcia
force-pushed
the
se_mgr_lib
branch
from
fe07067 to
d26c0bc
Compare
diemol
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Selenium Manager Rust logic to be used as lib crate (see reference for publishing Rust crates in crates.io).
Motivation and Context
This PR implements #11132. Moreover, this PR prepares the Selenium Manager logic for M3, devoted to rich configuration.
Types of changes
Checklist