[grid] Accommodate ability to specify sub-paths by krmahadevan · Pull Request #11271 · SeleniumHQ/selenium

krmahadevan · 2022-11-16T11:00:30Z

Sub-paths can now be specified for the below
Components:

Hub
Standalone
Router

It can be specified via --sub-path <actualPathGoesHere>

Or via the Toml configuration file by specifying

[reverse_proxy]
sub-path = “<actualPathGoesHere>”

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Sub-paths can now be specified for the below
Components:

Hub
Standalone
Router

It can be specified via “--sub-path ”

Or via the Toml configuration file by specifying

[reverse_proxy]
sub-path = “”

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

krmahadevan · 2022-11-16T11:01:56Z

@diemol - I have only run bazel test --cache_test_results=no java/test/org/openqa/selenium/grid/router:medium-tests

diemol

Thank you, @krmahadevan!

Left some comments so we can iterate.

yashcho · 2022-11-24T12:19:15Z

Any update @diemol ?

codecov-commenter · 2022-12-08T03:32:21Z

Codecov Report

Base: 54.54% // Head: 54.54% // No change to project coverage 👍

Coverage data is based on head (e2ed7a3) compared to base (4f218e0).
Patch has no changes to coverable lines.

❗ Current head e2ed7a3 differs from pull request most recent head e6063eb. Consider uploading reports for the commit e6063eb to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #11271   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          85       85           
  Lines        5627     5627           
  Branches      243      243           
=======================================
  Hits         3069     3069           
  Misses       2315     2315           
  Partials      243      243

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

diemol

Thank you, @krmahadevan! Just a minor change requested from my side.

krmahadevan · 2022-12-13T02:43:53Z

@diemol - I have addressed the last review comment, rebased off of trunk and force pushed this branch. Please take a look. I will send a separate PR for this for addressing the documentation needs.

diemol

Thank you, @krmahadevan!

Fixes: SeleniumHQ#10847 Sub-paths can now be specified for the below Components: 1. Hub 2. Standalone 3. Router It can be specified via “--sub-path <actualPathGoesHere>” Or via the Toml configuration file by specifying [reverse_proxy] sub-path = “<actualPathGoesHere>”

sonarqubecloud · 2022-12-15T06:58:22Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

yashcho · 2023-01-27T16:32:32Z

@diemol / @krmahadevan any idea in which release is it planned to rollout?

titusfortner · 2023-01-27T17:42:21Z

Should be available in 4.8 (the latest release)

yashcho · 2023-01-30T05:31:24Z

Thank you @titusfortner for information but I don't see it in release notes, even any idea on how it will work for docker-selenium?

diemol · 2023-01-30T08:55:00Z

I will publish the release blog post today. What is missing is the documentation for this feature in the docs.

yashcho · 2023-01-30T09:12:11Z

Thank you @diemol as I didn't work completely on creating this feature it would be difficult for me to write docs.

diemol · 2023-01-30T09:14:08Z

Apologies if my comment was ambiguous, @yashcho. I meant, we at Selenium need to document the feature.

yashcho · 2023-01-30T10:47:09Z

Understood, I would wait for the release note and feature doc.. :-)

krmahadevan force-pushed the add_support_sub_path branch 2 times, most recently from 64ce334 to 6d385d4 Compare November 17, 2022 10:30

krmahadevan changed the title ~~Accommodate ability to specify sub-paths~~ [grid] Accommodate ability to specify sub-paths Nov 17, 2022

diemol requested changes Nov 17, 2022

View reviewed changes

Comment thread java/src/org/openqa/selenium/grid/server/ReverseProxyFlags.java Outdated

Comment thread java/src/org/openqa/selenium/grid/server/ReverseProxyOptions.java Outdated

Comment thread java/src/org/openqa/selenium/grid/web/GridUiRoute.java Outdated

krmahadevan force-pushed the add_support_sub_path branch 2 times, most recently from 510b5c2 to 42e709e Compare November 17, 2022 17:32

krmahadevan requested a review from diemol November 17, 2022 17:39

krmahadevan force-pushed the add_support_sub_path branch from 42e709e to 78d8a96 Compare November 28, 2022 03:49

titusfortner added the B-grid Everything grid and server related label Nov 28, 2022

krmahadevan force-pushed the add_support_sub_path branch 2 times, most recently from 137b684 to 3be9e09 Compare December 8, 2022 03:13

diemol force-pushed the add_support_sub_path branch from 3be9e09 to 78ff30a Compare December 12, 2022 13:10

diemol requested changes Dec 12, 2022

View reviewed changes

Comment thread java/src/org/openqa/selenium/grid/router/httpd/RouterOptions.java Outdated

krmahadevan force-pushed the add_support_sub_path branch from 78ff30a to e6063eb Compare December 13, 2022 02:42

diemol approved these changes Dec 14, 2022

View reviewed changes

diemol force-pushed the add_support_sub_path branch from e6063eb to 04192a4 Compare December 14, 2022 22:47

krmahadevan added 5 commits December 15, 2022 07:38

Fixing review comments

42e0123

Fixing build dependencies

0b6bb55

Simplify route building logic

5c94421

Renaming the flag to “network”

e4af3c7

diemol force-pushed the add_support_sub_path branch from 04192a4 to e4af3c7 Compare December 15, 2022 06:38

diemol merged commit 2917a66 into SeleniumHQ:trunk Dec 15, 2022

krmahadevan deleted the add_support_sub_path branch December 15, 2022 10:20

krmahadevan mentioned this pull request Feb 13, 2023

[🚀 Feature]: Allow user to provide a different base URL for the grid UI #11647

Closed

Uh oh!

Conversation

krmahadevan commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

krmahadevan commented Nov 16, 2022

Uh oh!

diemol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yashcho commented Nov 24, 2022

Uh oh!

codecov-commenter commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

diemol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

krmahadevan commented Dec 13, 2022

Uh oh!

diemol left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Dec 15, 2022

Uh oh!

yashcho commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

titusfortner commented Jan 27, 2023

Uh oh!

yashcho commented Jan 30, 2023

Uh oh!

diemol commented Jan 30, 2023

Uh oh!

yashcho commented Jan 30, 2023

Uh oh!

diemol commented Jan 30, 2023

Uh oh!

yashcho commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

krmahadevan commented Nov 16, 2022 •

edited

Loading

codecov-commenter commented Dec 8, 2022 •

edited

Loading

yashcho commented Jan 27, 2023 •

edited

Loading