[java] Return new input stream to allow multiple reads#11249
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom Nov 11, 2022
Merged
[java] Return new input stream to allow multiple reads#11249diemol merged 1 commit intoSeleniumHQ:trunkfrom
diemol merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Codecov ReportBase: 52.69% // Head: 52.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #11249 +/- ##
=======================================
Coverage 52.69% 52.69%
=======================================
Files 82 82
Lines 5545 5545
Branches 198 198
=======================================
Hits 2922 2922
Misses 2425 2425
Partials 198 198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
SonarCloud Quality Gate failed. |
diemol
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Related to #11068 .
Motivation and Context
ProtocolHanshake returns a supplier with the same InputStream instance each time for a POST request body. This causes problems when the HttpClient needs to read the POST request body more than once. To ensure multiple reads are allowed, the chances returns a new instance of InputStream each time. The changes are inspired from the Selenium's memoized supplier.
Types of changes
Checklist