Skip to content

[py] Change formatted strings to f-strings#11087

Merged
diemol merged 6 commits intoSeleniumHQ:trunkfrom
kianelbo:f-str
Dec 7, 2022
Merged

[py] Change formatted strings to f-strings#11087
diemol merged 6 commits intoSeleniumHQ:trunkfrom
kianelbo:f-str

Conversation

@kianelbo
Copy link
Copy Markdown
Contributor

@kianelbo kianelbo commented Oct 5, 2022

Description

Replace legacy formatted strings with f-strings

Closes #11084

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [n/a] My change requires a change to the documentation.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@symonk
Copy link
Copy Markdown
Member

symonk commented Oct 5, 2022

Thanks @kianelbo just going to eat then will review, much appreciated

@symonk
Copy link
Copy Markdown
Member

symonk commented Oct 5, 2022

minor conflict from some typing I recently added in wait.py, apart from that LGTM 👍

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 55.49% // Head: 55.49% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a41dcc6) compared to base (dcdff48).
Patch coverage: 35.84% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk   #11087      +/-   ##
==========================================
- Coverage   55.49%   55.49%   -0.01%     
==========================================
  Files          82       82              
  Lines        5503     5498       -5     
  Branches      278      278              
==========================================
- Hits         3054     3051       -3     
+ Misses       2171     2169       -2     
  Partials      278      278
Impacted Files Coverage Δ
...selenium/webdriver/common/actions/pointer_input.py 35.55% <0.00%> (ø)
py/selenium/webdriver/common/bidi/cdp.py 31.57% <0.00%> (ø)
...selenium/webdriver/firefox/extension_connection.py 36.58% <0.00%> (ø)
py/selenium/webdriver/firefox/firefox_binary.py 30.82% <ø> (+0.23%) ⬆️
py/selenium/webdriver/firefox/firefox_profile.py 34.78% <0.00%> (+0.16%) ⬆️
py/selenium/webdriver/remote/errorhandler.py 61.02% <0.00%> (ø)
py/selenium/webdriver/remote/remote_connection.py 59.22% <0.00%> (ø)
py/selenium/webdriver/remote/webelement.py 38.98% <0.00%> (-0.13%) ⬇️
py/selenium/webdriver/support/wait.py 70.58% <0.00%> (-1.97%) ⬇️
py/selenium/webdriver/support/select.py 27.27% <20.00%> (-0.60%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner titusfortner added the C-py Python Bindings label Oct 17, 2022
@kianelbo
Copy link
Copy Markdown
Contributor Author

kianelbo commented Dec 5, 2022

@symonk any plans to merge this?

@kianelbo kianelbo closed this Dec 5, 2022
@kianelbo kianelbo reopened this Dec 5, 2022
diemol
diemol approved these changes Dec 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kianelbo!

@diemol diemol merged commit d8b45c8 into SeleniumHQ:trunk Dec 7, 2022
@kianelbo kianelbo deleted the f-str branch December 7, 2022 18:42
@nithishayadav nithishayadav mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

C-py Python Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Python upgrade to f-strings [good first issue]

6 participants

@kianelbo @CLAassistant @symonk @codecov-commenter @diemol @titusfortner