Skip to content

Fix javadoc#10992

Merged
titusfortner merged 4 commits intoSeleniumHQ:trunkfrom
baflQA:fixJavadoc
Sep 4, 2022
Merged

Fix javadoc#10992
titusfortner merged 4 commits intoSeleniumHQ:trunkfrom
baflQA:fixJavadoc

Conversation

@baflQA
Copy link
Copy Markdown
Contributor

@baflQA baflQA commented Sep 1, 2022 •
edited
Loading

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

No functional changes - just pointing to the non-deprecated method in JavaDocs plus some more functional style refactoring.

Motivation and Context

Make things a little bit better

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

titusfortner
titusfortner requested changes Sep 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an error in CI for this — https://github.com/SeleniumHQ/selenium/runs/8132498768?check_suite_focus=true#step:6:81

@titusfortner titusfortner added the C-java Java Bindings label Sep 4, 2022
@baflQA
Copy link
Copy Markdown
Contributor Author

baflQA commented Sep 4, 2022

Getting an error in CI for this — https://github.com/SeleniumHQ/selenium/runs/8132498768?check_suite_focus=true#step:6:81

Hmm, that is weird... This API method was introduced in JDK10... I will remove this change, as it was just some housekeeping, not the main reason for filing this PR ;)

@baflQA baflQA requested a review from titusfortner September 4, 2022 19:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 4, 2022 •
edited
Loading

Codecov Report

Merging #10992 (4f078db) into trunk (b72224f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10992   +/-   ##
=======================================
  Coverage   53.19%   53.19%           
=======================================
  Files          84       84           
  Lines        5484     5484           
  Branches      272      272           
=======================================
  Hits         2917     2917           
  Misses       2295     2295           
  Partials      272      272

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@titusfortner
Copy link
Copy Markdown
Member

titusfortner commented Sep 4, 2022

Yeah, we compile with 11, but still support 8. Would love to require later versions, but people hate changing jvms.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@titusfortner titusfortner merged commit 5050a6b into SeleniumHQ:trunk Sep 4, 2022
@baflQA baflQA deleted the fixJavadoc branch September 4, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titusfortner titusfortner Awaiting requested review from titusfortner

Assignees

No one assigned

Labels

C-java Java Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baflQA @codecov-commenter @titusfortner