Skip to content

chore/code style changes, add util#10975

Merged
harsha509 merged 4 commits intoSeleniumHQ:trunkfrom
potapovDim:chore/code-style-changes-util
Aug 28, 2022
Merged

chore/code style changes, add util#10975
harsha509 merged 4 commits intoSeleniumHQ:trunkfrom
potapovDim:chore/code-style-changes-util

Conversation

@potapovDim
Copy link
Copy Markdown
Contributor

@potapovDim potapovDim commented Aug 25, 2022

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Changes in code style, add util functions file

Description

Changes in code style, add util functions file

Motivation and Context

Align code style format

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@potapovDim
Copy link
Copy Markdown
Contributor Author

potapovDim commented Aug 25, 2022

@harsha509 Hi, can you take a look, please ?

@harsha509
Copy link
Copy Markdown
Member

harsha509 commented Aug 25, 2022 •
edited
Loading

Thank you @potapovDim !

LGTM!

Waiting for CI checks!

@potapovDim
Copy link
Copy Markdown
Contributor Author

potapovDim commented Aug 25, 2022

@harsha509 some fails, but does not look like that it is related to my changes

@harsha509
Copy link
Copy Markdown
Member

harsha509 commented Aug 25, 2022

@harsha509 some fails, but does not look like that it is related to my changes

Sure,

Looks like Firefox tests are failing, I will look into it!

@potapovDim
Copy link
Copy Markdown
Contributor Author

potapovDim commented Aug 28, 2022

@harsha509 hi, any updates ?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harsha509
Copy link
Copy Markdown
Member

harsha509 commented Aug 28, 2022

@harsha509 hi, any updates ?

I see window tests are failing in firefox. Am sure those failures are nothing to do with these changes.
Will merge the pr!

@harsha509
Copy link
Copy Markdown
Member

harsha509 commented Aug 28, 2022

Thank you @potapovDim !

@harsha509 harsha509 merged commit 51095a4 into SeleniumHQ:trunk Aug 28, 2022
@potapovDim potapovDim deleted the chore/code-style-changes-util branch August 28, 2022 08:46
@potapovDim
Copy link
Copy Markdown
Contributor Author

potapovDim commented Aug 28, 2022

@harsha509 i checked builds in trunk and there are many fails with firefox browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@potapovDim @harsha509