feat(java): add webdriver.edge.loglevel#10962
Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom Aug 22, 2022
Merged
Conversation
It adds a new system property `webdriver.edge.loglevel` on EdgeDriverService. It allows us to configure the log level in detail. For example, if you use version 104.0.1293.63 Microsoft Edge WebDriver, you can choose one from ALL, DEBUG, INFO, WARNING, SEVERE, or OFF. ``` $ ./msedgedriver --help --log-level=LEVEL set log level: ALL, DEBUG, INFO, WARNING, SEVERE, OFF ``` What this system property does is to make sure to specify the `--log-level` option like the others. Fixes SeleniumHQ#10961
diemol
approved these changes
Aug 22, 2022
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
It adds a new system property,
webdriver.edge.loglevelon EdgeDriverService.It allows us to configure the log level in detail.
For example, if you use version 104.0.1293.63 Microsoft Edge WebDriver, you can choose one from ALL, DEBUG, INFO, WARNING, SEVERE, or OFF.
What this system property does is to make sure to specify the
--log-leveloption like the others.Detail: validation of given string
When users provide an invalid log level, MsEdgeDriver will be terminated due to an error;
Invalid --log-level value.I wondered if I should validate if a given value is valid, but I didn't implement it because I was concerned that support costs would be high. For example, it is an extreme case, but we might need to have a log level list for each version when MsEdgeDriver adds or removes log levels, etc.
Motivation and Context
Fixes #10961
Types of changes
Checklist