Skip to content

Deprecation notice about urllib3[secure] in setup.py#10932

Merged
symonk merged 4 commits intoSeleniumHQ:trunkfrom
fyunusa:trunk
Aug 14, 2022
Merged

Deprecation notice about urllib3[secure] in setup.py#10932
symonk merged 4 commits intoSeleniumHQ:trunkfrom
fyunusa:trunk

Conversation

@fyunusa
Copy link
Copy Markdown
Contributor

@fyunusa fyunusa commented Aug 10, 2022

Description

pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)
urllib3/urllib3#2680
Removed [secure] extra from the urllib3 dependency in setup.py
Changed 'urllib3[secure, socks]=1.26 to 'urllib3[socks]=1.26'

 pyOpenSSL and urllib3[secure] are deprecated in the upcoming release of (1.26.12)
Removed [secure] extra from the urllib3 dependencies
pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)
urllib3/urllib3#2680
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 10, 2022

CLA assistant check
All committers have signed the CLA.

@symonk
Copy link
Copy Markdown
Member

symonk commented Aug 10, 2022

Thanks @umarfarouk98, its slightly more complicated in the project due to multi languages and using bazel. I think we also need to change the following here: https://github.com/SeleniumHQ/selenium/blob/trunk/py/BUILD.bazel

Removed urllib3[secure] dependency
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #10932 (0b1948c) into trunk (afe2884) will not change coverage.
The diff coverage is n/a.

❗ Current head 0b1948c differs from pull request most recent head f5ce547. Consider uploading reports for the commit f5ce547 to get more accurate results

@@           Coverage Diff           @@
##            trunk   #10932   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files          84       84           
  Lines        5480     5480           
  Branches      279      279           
=======================================
  Hits         2764     2764           
  Misses       2437     2437           
  Partials      279      279           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@symonk symonk added the C-py Python Bindings label Aug 11, 2022
@symonk symonk self-requested a review August 12, 2022 10:55
Copy link
Copy Markdown
Member

@symonk symonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fyunusa
Copy link
Copy Markdown
Contributor Author

fyunusa commented Aug 12, 2022

Thanks!

@symonk you wlcm.
Anything else i need to do on the request for it to get merge just let me know

@symonk
Copy link
Copy Markdown
Member

symonk commented Aug 14, 2022

I couldn't find any reference to the secure extra in any requirements files either, so I think this LGTM (my bazel knowledge is very light 😄 )

@symonk symonk merged commit 95f0cba into SeleniumHQ:trunk Aug 14, 2022
@fyunusa
Copy link
Copy Markdown
Contributor Author

fyunusa commented Aug 14, 2022

I couldn't find any reference to the secure extra in any requirements files either, so I think this LGTM (my bazel knowledge is very light 😄 )

it's not @symonk it's true that the Build.bazel contained the secure[extra] dependency initially but i removed it already.
Screenshot 2022-08-14 at 9 34 20 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants