Skip to content

[JS]add support to switch frame by name#10670

Merged
harsha509 merged 1 commit intoSeleniumHQ:trunkfrom
gravityvi:features/add-support-to-switch-frame-by-name
May 19, 2022
Merged

[JS]add support to switch frame by name#10670
harsha509 merged 1 commit intoSeleniumHQ:trunkfrom
gravityvi:features/add-support-to-switch-frame-by-name

Conversation

@gravityvi
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

added support to switch frame by name param.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

harsha509
harsha509 previously approved these changes May 19, 2022
Copy link
Copy Markdown
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gravityvi !

@harsha509
Copy link
Copy Markdown
Member

Hi @gravityvi ,

Could you please sign the CLA to get this merged!

@gravityvi gravityvi force-pushed the features/add-support-to-switch-frame-by-name branch from cddcf1b to 2a4d190 Compare May 19, 2022 15:39
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harsha509
Copy link
Copy Markdown
Member

Merging as JS checks are fine!

@harsha509 harsha509 merged commit f715038 into SeleniumHQ:trunk May 19, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants