[java] implement separate Origin class for WheelInput#10636
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom May 12, 2022
Merged
[java] implement separate Origin class for WheelInput#10636diemol merged 1 commit intoSeleniumHQ:trunkfrom
diemol merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10636 +/- ##
=======================================
Coverage 45.58% 45.58%
=======================================
Files 86 86
Lines 5739 5739
Branches 274 274
=======================================
Hits 2616 2616
Misses 2849 2849
Partials 274 274 Continue to review full report at Codecov.
|
pujagani
approved these changes
May 12, 2022
Contributor
pujagani
left a comment
pujagani
left a comment
There was a problem hiding this comment.
I did bump across this when implementing scroll but was not sure which is the best way to go due to code repetition. This is definitely a cleaner approach. Thank you @titusfortner!
diemol
force-pushed
the
java_scroll_origin
branch
from
3a41266 to
4eff61d
Compare
diemol
approved these changes
May 12, 2022
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what I was talking about in the TLC meeting. I'd rather have a separate implementation than use one from another (tangential but still unrelated) class that has an unsupported method that we have to treat differently.
(I also have an idea for how I'd like to build on this class in a way that requires it to be independent).