Skip to content

[py] use typing_extensions to be compatible with py37#10613

Merged
AutomatedTester merged 1 commit intoSeleniumHQ:trunkfrom
symonk:10612-using-non-py37-literal-type
May 5, 2022
Merged

[py] use typing_extensions to be compatible with py37#10613
AutomatedTester merged 1 commit intoSeleniumHQ:trunkfrom
symonk:10612-using-non-py37-literal-type

Conversation

@symonk
Copy link
Copy Markdown
Member

@symonk symonk commented May 5, 2022

typing.Literal is only available in py3.8+; this patch uses typing-extensions for older versions.

closes #10612

@symonk
Copy link
Copy Markdown
Member Author

symonk commented May 5, 2022

@diemol CI is running under python 3.8.10 as mentioned; we need to fix that as soon as poss. and the chrome fails are flaky tests by the looks of it

@AutomatedTester AutomatedTester merged commit 56a35d9 into SeleniumHQ:trunk May 5, 2022
@symonk symonk deleted the 10612-using-non-py37-literal-type branch May 5, 2022 14:48
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: 4.1.4 Released but only working with Python 3.8+

2 participants