[JS] handle a breaking changes in os.networkInterfaces#10611
Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom May 5, 2022
Merged
[JS] handle a breaking changes in os.networkInterfaces#10611diemol merged 2 commits intoSeleniumHQ:trunkfrom
diemol merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
In Node 18+, os.networkInterface's family is either 4 or 6, os.networkInterface's family was either IPv4 or IPv6 until Node 16 Signed-off-by: Outsider <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
) In Node 18+, os.networkInterface's family is either 4 or 6, os.networkInterface's family was either IPv4 or IPv6 until Node 16 Signed-off-by: Outsider <[email protected]> Co-authored-by: Diego Molina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Until Node 16,
os.networkInterfaces()'sfamilyis eitherIPv4orIPv6.However, in Node 18,
os.networkInterfaces()'sfamilyis either4(for IPv4) or6(for IPv6).So, this patch can handle both
IPv4/IPv6and4/6.Motivation and Context
When I run tests for my project with Node 18, I failed because selenium-webdriver can't get any network interfaces.
Types of changes
Checklist