[py] Bugfix: text_to_be_present_in_element_attribute predicate checking#10596
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom May 1, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10596 +/- ##
=======================================
Coverage 45.02% 45.02%
=======================================
Files 85 85
Lines 5508 5508
Branches 268 268
=======================================
Hits 2480 2480
Misses 2760 2760
Partials 268 268
Continue to review full report at Codecov.
|
diemol
approved these changes
May 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor tweak for
text_to_be_present_in_element_attributewhich is referencing another expected condition however it is evaluating the result of that call in a boolean context; that function is returning a predicate function and not it's respective boolean return type.closes #10592