python: test function names tidy up inline with pep8 #10490
Merged
AutomatedTester merged 5 commits intoSeleniumHQ:trunkfrom Apr 7, 2022
Merged
python: test function names tidy up inline with pep8 #10490AutomatedTester merged 5 commits intoSeleniumHQ:trunkfrom
python: test function names tidy up inline with pep8 #10490AutomatedTester merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10490 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 85 85
Lines 5522 5522
Branches 268 268
=======================================
Hits 2488 2488
Misses 2766 2766
Partials 268 268 Continue to review full report at Codecov.
|
AutomatedTester
approved these changes
Apr 7, 2022
Member
|
thanks for the PR |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
) * `python`: apply pep8 compliant snake case to tests * fix fallout from commented test changes; update everything inside `py/test/` Co-authored-by: David Burns <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rather crazy one, apologies whoever reviews! I noticed a lot of the tests use a camel case naming, in python we should opt for snake case as best as possible; with the help of regex & the
string manipulationplugin for pycharm (highly recommend it!) I've went through all thedef test*functions inside/py/test/selenium*and rejigged them into snake case.This also has some extra pieces of:
Kinda relying on CI to give me a steer in any fallout here; but I was quite meticulous when going through it; so should be minimal (I hope).