[py] remove unused kind arg of WheelInput#10463
Merged
titusfortner merged 5 commits intoSeleniumHQ:trunkfrom May 9, 2022
Merged
[py] remove unused kind arg of WheelInput#10463titusfortner merged 5 commits intoSeleniumHQ:trunkfrom
kind arg of WheelInput#10463titusfortner merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
symonk
changed the title
kind arg of WheelInputkind arg of WheelInput
Codecov Report
@@ Coverage Diff @@
## trunk #10463 +/- ##
=======================================
Coverage 45.02% 45.02%
=======================================
Files 85 85
Lines 5508 5508
Branches 268 268
=======================================
Hits 2480 2480
Misses 2760 2760
Partials 268 268
Continue to review full report at Codecov.
|
symonk
changed the title
kind arg of WheelInputpython: remove unused kind arg of WheelInput
symonk
changed the title
python: remove unused kind arg of WheelInputkind arg of WheelInput
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10210, this method looks like it blindly copy/pasted from
add_pointer_input(...)originally. Still need to add a test for this and looking atWheelInputin general it looks a little neglected/unused, will try understand what it's for exactly and tidy up.(tests incoming when my local setup is working shortly)
I suspect there is more work to do on this class; some instances are being passed
name=interaction.WHEELbut it defines internally aself.type=interaction.WHEELso possibly other bugs there as well.