[python] replace misuses of typing.NoReturn#10462
Merged
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom Apr 8, 2022
Merged
[python] replace misuses of typing.NoReturn#10462AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
typing.NoReturn#10462AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
Conversation
symonk
changed the title
typing.NoReturn in ChromiumOptionstyping.NoReturn in ChromiumOptions
Codecov Report
@@ Coverage Diff @@
## trunk #10462 +/- ##
==========================================
- Coverage 45.05% 45.00% -0.05%
==========================================
Files 85 85
Lines 5522 5519 -3
Branches 268 268
==========================================
- Hits 2488 2484 -4
- Misses 2766 2767 +1
Partials 268 268
Continue to review full report at Codecov.
|
symonk
commented
Mar 20, 2022
|
|
||
| def quit(self) -> NoReturn: | ||
| def quit(self) -> None: | ||
| RemoteWebDriver.quit(self) |
Member
Author
There was a problem hiding this comment.
Todo: consider super() in this class in general, will address in a seperate ticket
symonk
changed the title
typing.NoReturn in ChromiumOptionstyping.NoReturn
AutomatedTester
approved these changes
Apr 8, 2022
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
* replace incorrect uses of `typing.NoReturn` in `ChromiumOptions` * fix other misuses of `typing.NoReturn` Co-authored-by: David Burns <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent introduction of typing has a few incorrect use cases; This patch addresses misuses of
typing.NoReturnwhich should be used when a function has no possibility of returning, mostly used incorrectly in place ofNoneon various setters. I will audit the other uses ofNoReturnthroughout; consider this a start for now.closes #10429 (eventually)
Types of changes
Checklist