Skip to content

Add Hook options class in safari driver#10433

Merged
AutomatedTester merged 2 commits intoSeleniumHQ:trunkfrom
MWschutte:py-safari-hook-options-into-driver
Mar 17, 2022
Merged

Add Hook options class in safari driver#10433
AutomatedTester merged 2 commits intoSeleniumHQ:trunkfrom
MWschutte:py-safari-hook-options-into-driver

Conversation

@MWschutte
Copy link
Copy Markdown
Contributor

@MWschutte MWschutte commented Mar 10, 2022 •
edited
Loading

Description

To be able to use Options in safari webdriver it should be hooked to the driver class.

Motivation and Context

See this issue #10428

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@AutomatedTester
Copy link
Copy Markdown
Member

AutomatedTester commented Mar 17, 2022

Thank you for the PR!

@AutomatedTester AutomatedTester merged commit 97bfeab into SeleniumHQ:trunk Mar 17, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@MWschutte @pujagani @elgatov
Hook options class in safari driver (SeleniumHQ#10433)
2b58c8d 
Co-authored-by: Puja Jagani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Selenium 4.2.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MWschutte @AutomatedTester @pujagani