Running workflows based on affected bazel targets#10405
Merged
Conversation
Ideally, we check the affected bazel targets, and then we decide to run the workflow or not.
and using ${GITHUB_BASE_REF}
# Conflicts: # .github/workflows/java-ci.yml
diemol
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, we have been using GitHub paths to decide when to run a workflow or not. However, this is not always accurate because one might need to build bazel targets from other code path and then the configuration gets tricky.
This PR changes that, analyses the diff to figure out if any bazel target is affected, and based on the code path, it is decided if the whole workflow will be executed or not.
So, there will be a main workflow (
dispatch-workflows.yml) that will run on PRs and push totrunk, and based on the changeset, it will trigger the desired workflow.In addition, to avoid corner cases, all workflows are scheduled to be run twice a day. With that, we can catch things that the improved workflow did not catch.
A follow up PR should be created to filter the workflow execution by the affected bazel targets.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist