[java] Fix modifier keys scope on Java Actions#10333
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom Feb 6, 2022
Merged
Conversation
As the defiination in SingleKeyAction.java, the modifier keys are from below array and the description highlight that "if the provided key is none of those, IllegalArgumentException is thrown", so update the code to match the scope. Keys.SHIFT, Keys.CONTROL, Keys.ALT, Keys.META, Keys.COMMAND, Keys.LEFT_ALT, Keys.LEFT_CONTROL, Keys.LEFT_SHIFT
|
Kudos, SonarCloud Quality Gate passed!
|
diemol
approved these changes
Feb 6, 2022
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
As the defiination in SingleKeyAction.java, the modifier keys are from below array and the description highlight that "if the provided key is none of those, IllegalArgumentException is thrown", so update the code to match the scope. Keys.SHIFT, Keys.CONTROL, Keys.ALT, Keys.META, Keys.COMMAND, Keys.LEFT_ALT, Keys.LEFT_CONTROL, Keys.LEFT_SHIFT [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add Keys.META and Keys.COMMAND as the modifier keys into Actions.java
Motivation and Context
As the defiination in SingleKeyAction.java, the modifier keys are from below array and the description highlight that "if the provided key is none of those, IllegalArgumentException is thrown", so update the code to match the scope.
Keys.SHIFT, Keys.CONTROL, Keys.ALT, Keys.META, Keys.COMMAND, Keys.LEFT_ALT, Keys.LEFT_CONTROL, Keys.LEFT_SHIFTTypes of changes
Checklist