Skip to content

add deleteNetworkConditions for chromium#10323

Merged
harsha509 merged 1 commit intoSeleniumHQ:trunkfrom
slhck:delete-network-conditions
Feb 4, 2022
Merged

add deleteNetworkConditions for chromium#10323
harsha509 merged 1 commit intoSeleniumHQ:trunkfrom
slhck:delete-network-conditions

Conversation

@slhck
Copy link
Copy Markdown
Contributor

@slhck slhck commented Feb 4, 2022

This implements the functionality to delete previously set network conditions
in Chromium.

Fixes #10322

Description

Adds the deleteNetworkConditions public method to the Chromium Driver.

Motivation and Context

The method was missing for Javascript.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 4, 2022

CLA assistant check
All committers have signed the CLA.

@slhck slhck force-pushed the delete-network-conditions branch from e41a209 to 90c6f58 Compare February 4, 2022 12:58
This implements the functionality to delete previously set network conditions
in Chromium.

Fixes SeleniumHQ#10322
@slhck slhck force-pushed the delete-network-conditions branch from 90c6f58 to 1e07df7 Compare February 4, 2022 13:01
Copy link
Copy Markdown
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harsha509 harsha509 merged commit 9f22905 into SeleniumHQ:trunk Feb 4, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
This implements the functionality to delete previously set network conditions
in Chromium.

Fixes SeleniumHQ#10322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: deleteNetworkConditions missing in Javascript

3 participants