Skip to content

[py] Add py.typed file#10310

Merged
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
Akuli:py-typed
Feb 2, 2022
Merged

[py] Add py.typed file#10310
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
Akuli:py-typed

Conversation

@Akuli
Copy link
Copy Markdown
Contributor

@Akuli Akuli commented Jan 31, 2022

Description

Makes type checkers use type annotations from selenium itself.

Motivation and Context

#9480

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Let me know if I have to go through the boilerplate, but I verified it manually: after pip install ./py in the repo, I can successfully run mypy over a file containing import selenium.

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Akuli
Copy link
Copy Markdown
Contributor Author

Akuli commented Jan 31, 2022

Sorry, where can I find the CLA? I have grepped in the repo, I have searched in CONTRIBUTING.md, and I have clicked the link in the above comment. All I find is references to "the CLA", e.g. a checkbox saying "I have read and agree to the CLA". So where is that CLA?

@diemol
Copy link
Copy Markdown
Member

diemol commented Jan 31, 2022

Sorry, where can I find the CLA? I have grepped in the repo, I have searched in CONTRIBUTING.md, and I have clicked the link in the above comment. All I find is references to "the CLA", e.g. a checkbox saying "I have read and agree to the CLA". So where is that CLA?

Probably we have an outdated link or comment somewhere, in the comment above you can see that this is a process supported by a tool.

@Akuli
Copy link
Copy Markdown
Contributor Author

Akuli commented Jan 31, 2022

From the link:

By submitting your Contribution to the Selenium Project, You hereby agree to license your Contribution under the Apache License, Version 2.0, and to include the appropriate copyright notice required by the license.

Is this "the CLA"?

@diemol
Copy link
Copy Markdown
Member

diemol commented Jan 31, 2022

image
https://cla-assistant.io/SeleniumHQ/selenium?pullRequest=10310

Yes

@Akuli
Copy link
Copy Markdown
Contributor Author

Akuli commented Jan 31, 2022

Thanks! Somehow I expected the CLA to be a wall of text of length 1 kilometre or so.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #10310 (3fd461f) into trunk (d18eac4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk   #10310   +/-   ##
=======================================
  Coverage   44.97%   44.97%           
=======================================
  Files          85       85           
  Lines        5479     5479           
  Branches      269      269           
=======================================
  Hits         2464     2464           
  Misses       2746     2746           
  Partials      269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5264548...3fd461f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 1729615 into SeleniumHQ:trunk Feb 2, 2022
@Akuli Akuli deleted the py-typed branch February 3, 2022 18:33
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@Akuli @elgatov
[py] Add py.typed file (SeleniumHQ#10310)
0a22b30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Akuli @CLAassistant @diemol @codecov-commenter @AutomatedTester