Skip to content

[dotnet] Fix toReturn["type"]#10304

Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom
eversoutheast:patch-1
Feb 2, 2022
Merged

[dotnet] Fix toReturn["type"]#10304
diemol merged 3 commits intoSeleniumHQ:trunkfrom
eversoutheast:patch-1

Conversation

@eversoutheast
Copy link
Copy Markdown
Contributor

@eversoutheast eversoutheast commented Jan 30, 2022

[🐛 Bug]: WheelScrollInteraction does not work for dotnet Selenium #10303

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

[🐛 Bug]: WheelScrollInteraction does not work for dotnet Selenium #10303
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2022

CLA assistant check
All committers have signed the CLA.

@eversoutheast eversoutheast changed the title Fix toReturn["type"] [dotnet] Fix toReturn["type"] Jan 30, 2022
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this, please?

@eversoutheast
Copy link
Copy Markdown
Contributor Author

Can you add a test for this, please?

Sorry. I'm not quite familiar with the build/test in Selenium dotnet solution.

@eversoutheast eversoutheast requested a review from diemol February 1, 2022 01:31
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diemol diemol merged commit 5264548 into SeleniumHQ:trunk Feb 2, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants