Elaborate find_element deprecation message#10273
Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom Jan 24, 2022
europeanplaice:dev_warnings
Merged
Elaborate find_element deprecation message#10273diemol merged 3 commits intoSeleniumHQ:trunkfrom europeanplaice:dev_warnings
diemol merged 3 commits intoSeleniumHQ:trunkfrom
europeanplaice:dev_warnings
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## trunk #10273 +/- ##
==========================================
- Coverage 44.98% 44.97% -0.02%
==========================================
Files 85 85
Lines 5477 5479 +2
Branches 269 269
==========================================
Hits 2464 2464
- Misses 2744 2746 +2
Partials 269 269
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
I'm glad I could help. |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
* make warnings detailed * Small fix Co-authored-by: Diego Molina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR gives more detailed deprecation information to the methods of
find_element_by_*.Motivation and Context
Though a user who uses
find_element_by_*may not know the grammar offind_element(), currently, the warnings don't suggest the usage of it. So the user has to look up the documentation, and it would be a little annoying. If the deprecation warnings gave enough information, it would save users' time.Types of changes
Checklist