[java] Fix FluentWait's sample usage wrt durations#10208
Merged
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom Dec 31, 2021
Merged
[java] Fix FluentWait's sample usage wrt durations#10208titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Commit 502301e removed some deprecated methods which used the deprecated TimeUnit class and kept only the overloaded methods that use Java's java.time.Duration class. However, it missed fixing the sample usage at the beginning of the javadoc that still referred to these methods. This patch fixes the issue and replaces the method calls in the sample usage with the newer methods that accept a Duration argument. Fixes SeleniumHQ#10207
|
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
Commit 502301e removed some deprecated methods which used the deprecated TimeUnit class and kept only the overloaded methods that use Java's java.time.Duration class. However, it missed fixing the sample usage at the beginning of the javadoc that still referred to these methods. This patch fixes the issue and replaces the method calls in the sample usage with the newer methods that accept a Duration argument. Fixes SeleniumHQ#10207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the sample usage of the
FluentWaitclass which currently does not compile.Motivation and Context
Commit 502301e removed some deprecated methods which used the deprecated
TimeUnitclass and kept only the overloaded methods that use Java'sjava.time.Durationclass.However, it missed fixing the sample usage at the beginning of the javadoc that still referred to these methods.
This patch fixes the issue and replaces the method calls in the sample usage with the newer methods that accept a
Durationargument.Types of changes
Checklist
Fixes #10207