Skip to content

[java] Update toJson() method creation for integer type in CdpClientGenerator#10200

Merged
pujagani merged 2 commits intoSeleniumHQ:trunkfrom
pujagani:cdp-number-type
Dec 31, 2021
Merged

[java] Update toJson() method creation for integer type in CdpClientGenerator#10200
pujagani merged 2 commits intoSeleniumHQ:trunkfrom
pujagani:cdp-number-type

Conversation

@pujagani
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #10155

Motivation and Context

The changes fix the toJson() to return Number instead of String for Number type.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
57.1% 57.1% Duplication

@pujagani pujagani merged commit ad48d31 into SeleniumHQ:trunk Dec 31, 2021
@pujagani
Copy link
Copy Markdown
Contributor Author

Thank you @titusfortner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Expires field of Network.setCookie not serialized as double

2 participants