Skip to content

[py] PEP484 hints for py/selenium/webdriver/common/actions/key_input.py#10186

Merged
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
iampopovich:PEP-484_common/actions/key_input_hints
Dec 26, 2021
Merged

[py] PEP484 hints for py/selenium/webdriver/common/actions/key_input.py#10186
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
iampopovich:PEP-484_common/actions/key_input_hints

Conversation

@iampopovich
Copy link
Copy Markdown
Contributor

@iampopovich iampopovich commented Dec 26, 2021

Description

This PR adds type hints to selenium.webdriver.common.actions.key_input.py

Motivation and Context

This is a follow-up of #9482 to address #9480.
@AutomatedTester pls review

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 26, 2021 •
edited by codecov Bot
Loading

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.10%. Comparing base (a47dade) to head (efb113a).
⚠️ Report is 6513 commits behind head on trunk.

Files with missing lines Patch % Lines
py/selenium/webdriver/common/actions/key_input.py 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk   #10186      +/-   ##
==========================================
+ Coverage   44.88%   45.10%   +0.21%     
==========================================
  Files          86       86              
  Lines        5657     5665       +8     
  Branches      264      269       +5     
==========================================
+ Hits         2539     2555      +16     
+ Misses       2854     2841      -13     
- Partials      264      269       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@titusfortner titusfortner merged commit 50ff745 into SeleniumHQ:trunk Dec 26, 2021
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@iampopovich @elgatov
hints for py/selenium/webdriver/common/actions/key_input.py (Selenium…
08da9d0 
…HQ#10186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titusfortner titusfortner titusfortner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iampopovich @codecov-commenter @titusfortner