Skip to content

Java tests -- retry NettyAppServer start#10170

Merged
diemol merged 11 commits intotrunkfrom
java-tests
Jan 3, 2022
Merged

Java tests -- retry NettyAppServer start#10170
diemol merged 11 commits intotrunkfrom
java-tests

Conversation

@diemol
Copy link
Copy Markdown
Member

@diemol diemol commented Dec 20, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@diemol diemol marked this pull request as ready for review January 3, 2022 20:33
@diemol
Copy link
Copy Markdown
Member Author

diemol commented Jan 3, 2022

There are a couple of server tests still failing, but this should be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant