Skip to content

Support new Cast command added to Chrome Devtools#10150

Merged
titusfortner merged 7 commits intoSeleniumHQ:trunkfrom
cliffordcheng:patch-4
Dec 24, 2021
Merged

Support new Cast command added to Chrome Devtools#10150
titusfortner merged 7 commits intoSeleniumHQ:trunkfrom
cliffordcheng:patch-4

Conversation

@cliffordcheng
Copy link
Copy Markdown
Contributor

@cliffordcheng cliffordcheng commented Dec 14, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

StartDesktopMirroring() is recently added to DevTools.
https://chromium-review.googlesource.com/c/chromium/src/+/3290959

Motivation and Context

This will allow user to call and use start_desktop_mirroring in webdriver.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 14, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #10150 (c4730d3) into trunk (10fed03) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk   #10150      +/-   ##
==========================================
+ Coverage   44.88%   44.89%   +0.01%     
==========================================
  Files          86       86              
  Lines        5659     5666       +7     
  Branches      264      266       +2     
==========================================
+ Hits         2540     2544       +4     
- Misses       2855     2856       +1     
- Partials      264      266       +2     
Impacted Files Coverage Δ
...y/selenium/webdriver/chromium/remote_connection.py 11.76% <0.00%> (-0.74%) ⬇️
py/selenium/webdriver/remote/shadowroot.py 27.58% <41.66%> (+11.58%) ⬆️
py/selenium/webdriver/chromium/webdriver.py 54.02% <50.00%> (-0.10%) ⬇️
py/selenium/webdriver/support/color.py 98.43% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10bff7...c4730d3. Read the comment docs.

@cliffordcheng cliffordcheng marked this pull request as draft December 17, 2021 10:26
@cliffordcheng cliffordcheng marked this pull request as ready for review December 17, 2021 10:29
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@titusfortner titusfortner merged commit 341b454 into SeleniumHQ:trunk Dec 24, 2021
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
* Support new Cast command added to Chrome Devtools

* Update remote_connection.py

* Update remote_connection.py

* Update webdriver.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants