[py] update ShadowRoot find element signatures to match those in WebElement#10138
[py] update ShadowRoot find element signatures to match those in WebElement#10138AutomatedTester merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10138 +/- ##
=======================================
Coverage 44.87% 44.88%
=======================================
Files 86 86
Lines 5658 5659 +1
Branches 264 264
=======================================
+ Hits 2539 2540 +1
Misses 2855 2855
Partials 264 264
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
|
This is a zero value change. A more useful addition would be adding type hinting. |
|
Why do we merge it if it is a zero value change? |
|
I will finish off the patch with the type hinting |
|
This is not a zero value change. It was literally a feature request from a user who wanted to have the same method wrapper for both methods and couldn't. I only PR'd it instead of merging it because I thought there might have been a reason you didn't just copy/paste what you already had. If the WebElement methods had type hinting, I would have copied that over as well. |








@AutomatedTester just making sure there wasn't a reason the signatures were different.