[js] update code format, public API exports, remove deprecated legacy#10110
Merged
harsha509 merged 2 commits intoSeleniumHQ:trunkfrom Dec 3, 2021
Merged
Conversation
Contributor
Author
|
@harsha509 Hey, hope you are well, can you check my PR, please ? |
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
Hi @potapovDim, Yup checkResponse is deprecated. we need to use throwDecodeError Thank you @potapovDim ! |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist