[py] PEP484 hints for webdriver.common.actions.action_builder#10108
Merged
titusfortner merged 8 commits intoSeleniumHQ:trunkfrom Dec 24, 2021
iampopovich:PEP-484/webdriver_common_action_builder
Merged
[py] PEP484 hints for webdriver.common.actions.action_builder#10108titusfortner merged 8 commits intoSeleniumHQ:trunkfrom iampopovich:PEP-484/webdriver_common_action_builder
titusfortner merged 8 commits intoSeleniumHQ:trunkfrom
iampopovich:PEP-484/webdriver_common_action_builder
Conversation
…builder also method get_device_with was edited much more laconic new variant has the same execution time as old get_device_with method returns None (as old try/except) if no device was filtered try/except block is unnecessary anymore
Codecov Report
@@ Coverage Diff @@
## trunk #10108 +/- ##
==========================================
+ Coverage 44.90% 45.08% +0.17%
==========================================
Files 86 86
Lines 5663 5661 -2
Branches 265 266 +1
==========================================
+ Hits 2543 2552 +9
+ Misses 2855 2843 -12
- Partials 265 266 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
titusfortner
approved these changes
Dec 24, 2021
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…builder (SeleniumHQ#10108) also method get_device_with was edited much more laconic new variant has the same execution time as old get_device_with method returns None (as old try/except) if no device was filtered try/except block is unnecessary anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR adds type hints to
selenium.webdriver.common.actions.action_builderalso method
get_device_withwas edited much more laconicold:
new:
get_device_withMotivation and Context
This is a follow-up of #9482 to address #9480.
@AutomatedTester pls review
Types of changes
Checklist