Performance improvements#10105
Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom Dec 2, 2021
larrydiamond:trunk
Merged
Conversation
|
|
|
Kudos, SonarCloud Quality Gate passed! |
diemol
requested changes
Dec 1, 2021
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
@larrydiamond, thank you for this PR. However, we are not making any changes under the thoughtworks package name because it a legacy package and some code is deprecated. This willl be eventually phased out.
If you wish, please keep the change to Platform.java only and then I can merge this PR.
Contributor
Author
|
Done. |
diemol
approved these changes
Dec 2, 2021
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
Thank you, @larrydiamond!
Congrats on your first contribution! 🎉
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
* Performance improvements * Rolling back changes in the deprecated thoughtworks package Co-authored-by: Diego Molina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes are purely performance improvements to make Selenium run faster, there are no new features in this pull request.
Motivation and Context
These changes provide performance improvements only. The uses of StringBuffer below can be safely replaced with StringBuilder and avoid synchronization overhead. The change to use equalsIgnoreCase is faster and reduces memory consumption by eliminating many temporary strings.
Types of changes
Checklist