Skip to content

[py] PEP 484 type hints for selenium.webdriver.common.actions.wheel_input#10103

Merged
AutomatedTester merged 2 commits intoSeleniumHQ:trunkfrom
iampopovich:PEP-484/webdriver_common_wheel_input
Nov 30, 2021
Merged

[py] PEP 484 type hints for selenium.webdriver.common.actions.wheel_input#10103
AutomatedTester merged 2 commits intoSeleniumHQ:trunkfrom
iampopovich:PEP-484/webdriver_common_wheel_input

Conversation

@iampopovich
Copy link
Copy Markdown
Contributor

Description

This PR adds type hints to selenium.webdriver.common.actions.wheel_input
Code style was edited in according to 80 charachters ruller

Motivation and Context

This is a follow-up of #9482 to address #9480.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #10103 (d942cb0) into trunk (5c3ae44) will increase coverage by 0.07%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk   #10103      +/-   ##
==========================================
+ Coverage   44.87%   44.94%   +0.07%     
==========================================
  Files          86       86              
  Lines        5676     5680       +4     
  Branches      263      264       +1     
==========================================
+ Hits         2547     2553       +6     
+ Misses       2866     2863       -3     
- Partials      263      264       +1     
Impacted Files Coverage Δ
...y/selenium/webdriver/common/actions/wheel_input.py 50.00% <40.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3ae44...d942cb0. Read the comment docs.

@AutomatedTester AutomatedTester merged commit 60db0c1 into SeleniumHQ:trunk Nov 30, 2021
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants