Skip to content

[py] PEP 484 type hints for selenium.webdriver.chromium.options#10099

Merged
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
iampopovich:PEP-484/chromium_options_type_hints
Nov 29, 2021
Merged

[py] PEP 484 type hints for selenium.webdriver.chromium.options#10099
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
iampopovich:PEP-484/chromium_options_type_hints

Conversation

@iampopovich
Copy link
Copy Markdown
Contributor

@iampopovich iampopovich commented Nov 28, 2021

Description

This PR adds type hints to selenium.webdriver.chromium.options

Motivation and Context

This is a follow-up of #9482 to address #9480.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #10099 (1b68b0b) into trunk (b253787) will increase coverage by 0.19%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk   #10099      +/-   ##
==========================================
+ Coverage   44.70%   44.90%   +0.19%     
==========================================
  Files          86       86              
  Lines        5679     5679              
  Branches      262      263       +1     
==========================================
+ Hits         2539     2550      +11     
+ Misses       2878     2866      -12     
- Partials      262      263       +1
Impacted Files Coverage Δ
py/selenium/webdriver/chromium/options.py 65.27% <83.33%> (+12.50%) ⬆️
py/selenium/webdriver/opera/options.py 30.95% <0.00%> (+2.38%) ⬆️
py/selenium/webdriver/edge/options.py 57.89% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b253787...1b68b0b. Read the comment docs.

@AutomatedTester AutomatedTester merged commit 14c7667 into SeleniumHQ:trunk Nov 29, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iampopovich iampopovich deleted the PEP-484/chromium_options_type_hints branch November 29, 2021 13:31
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@iampopovich @AutomatedTester @elgatov
[py] PEP 484 type hints for selenium.webdriver.chromium.options (Sele…
3984c86 
…niumHQ#10099)

Co-authored-by: David Burns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iampopovich @CLAassistant @codecov-commenter @AutomatedTester