Skip to content

[js] update code format, public API exports#10097

Merged
harsha509 merged 1 commit intoSeleniumHQ:trunkfrom
potapovDim:feat/code-cleanup-iteration-5
Nov 28, 2021
Merged

[js] update code format, public API exports#10097
harsha509 merged 1 commit intoSeleniumHQ:trunkfrom
potapovDim:feat/code-cleanup-iteration-5

Conversation

@potapovDim
Copy link
Copy Markdown
Contributor

@potapovDim potapovDim commented Nov 28, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@potapovDim potapovDim changed the title update code format, public API exports [js] update code format, public API exports Nov 28, 2021
Copy link
Copy Markdown
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harsha509
Copy link
Copy Markdown
Member

Thank you @potapovDim !

@harsha509 harsha509 merged commit 941da9b into SeleniumHQ:trunk Nov 28, 2021
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants