Skip to content

[js] Remove legacy JWP support and w3c<boolean> switch (Cleanup-1)#10095

Merged
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
harsha509:trunk
Nov 30, 2021
Merged

[js] Remove legacy JWP support and w3c<boolean> switch (Cleanup-1)#10095
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom
harsha509:trunk

Conversation

@harsha509
Copy link
Copy Markdown
Member

@harsha509 harsha509 commented Nov 27, 2021 •
edited
Loading

Description

This PR

  • Removes support for legacy JWP (now strictly supports W3C protocol)
  • Removes W3C (boolean> switch which was introduced to switch between w3c(true) and non-w3c(false) command

Motivation and Context

To make JS bindings completely W3C-compliant (Removes JWP support)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509 harsha509 changed the title [js] Remove legacy JWP support and w3c<boolean> switch [js] Remove legacy JWP support and w3c<boolean> switch (Cleanup-1) Nov 27, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit bed68d1 into SeleniumHQ:trunk Nov 30, 2021
@harsha509
Copy link
Copy Markdown
Member Author

harsha509 commented Nov 30, 2021

Thank you @AutomatedTester!

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@harsha509 @elgatov
[js] Remove legacy JWP support and w3c<boolean> switch (SeleniumHQ#10095
bdc02bc 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harsha509 @AutomatedTester