#9784 use shutdown() instead of shutdownNow()#10063
Merged
pujagani merged 8 commits intoSeleniumHQ:trunkfrom Nov 24, 2021
asolntsev:wait-for-current-tasks-completion
Merged
#9784 use shutdown() instead of shutdownNow()#10063pujagani merged 8 commits intoSeleniumHQ:trunkfrom asolntsev:wait-for-current-tasks-completion
shutdown() instead of shutdownNow()#10063pujagani merged 8 commits intoSeleniumHQ:trunkfrom
asolntsev:wait-for-current-tasks-completion
Conversation
This was referenced Nov 20, 2021
pujagani
reviewed
Nov 22, 2021
it waits for completion of already started tasks. Otherwise it may causes errors in those tasks, including succeeding NoClassDefFoundError.
diemol
approved these changes
Nov 23, 2021
|
SonarCloud Quality Gate failed. |
Contributor
|
Thank you! @asolntsev |
diemol
added a commit
that referenced
this pull request
Dec 1, 2021
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…HQ#10063) * SeleniumHQ#9784 use `shutdown()` instead of `shutdownNow()` it waits for completion of already started tasks. Otherwise it may causes errors in those tasks, including succeeding NoClassDefFoundError. * SeleniumHQ#9784 shutdown gracefully the executor service Co-authored-by: Puja Jagani <[email protected]> Co-authored-by: Diego Molina <[email protected]>
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it waits for completion of already started tasks. Otherwise it may causes errors in those tasks, including succeeding NoClassDefFoundError.
Description
One more fix for #9784
Types of changes