Skip to content

Feat/9943 inject telemetry context#10024

Merged
pujagani merged 4 commits intoSeleniumHQ:trunkfrom
llatinov:feat/9943_inject_telemetry_context
Nov 23, 2021
Merged

Feat/9943 inject telemetry context#10024
pujagani merged 4 commits intoSeleniumHQ:trunkfrom
llatinov:feat/9943_inject_telemetry_context

Conversation

@llatinov
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Provide OpenTelemetry context from outside, in order to connect the custom tracing with Selenium traces.
Context is set with: OpenTelemetryTracer.getInstance().setOpenTelemetryContext(Context.current().with(span));

Fixes #9943

Motivation and Context

In order to be able to link a custom tracing with Selenium OpenTelemetry traces.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Provide OpenTelemetry context from outside,
in order to connect the custom tracing with Selenium traces.
Context is set with: OpenTelemetryTracer.getInstance()
.setOpenTelemetryContext(Context.current().with(span));

Fixes SeleniumHQ#9943
@pujagani pujagani force-pushed the feat/9943_inject_telemetry_context branch from 78647c6 to a0d4d25 Compare November 23, 2021 11:41
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujagani pujagani merged commit 6c2e844 into SeleniumHQ:trunk Nov 23, 2021
@pujagani
Copy link
Copy Markdown
Contributor

Thank you @llatinov !

@llatinov llatinov deleted the feat/9943_inject_telemetry_context branch November 23, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: OpenTelementry tracing: be able to link the default tracing with a custom tracing

2 participants