Skip to content

Commit ee6af75

Browse files
[py] Implement __hash__ and explicit ScriptKey equality comparison (#18243)
Co-authored-by: Corey Goldberg <[email protected]>
1 parent 30cf146 commit ee6af75

2 files changed

Lines changed: 60 additions & 1 deletion

File tree

‎py/selenium/webdriver/remote/script_key.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,13 @@ def __init__(self, id=None):
2626
def id(self):
2727
return self._id
2828

29-
def __eq__(self, other):
29+
def __eq__(self, other: object) -> bool:
30+
if isinstance(other, ScriptKey):
31+
return self._id == other._id
3032
return self._id == other
3133

34+
def __hash__(self) -> int:
35+
return hash(self._id)
36+
3237
def __repr__(self) -> str:
3338
return f"ScriptKey(id={self.id})"
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# Licensed to the Software Freedom Conservancy (SFC) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The SFC licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing,
12+
# software distributed under the License is distributed on an
13+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
# KIND, either express or implied. See the License for the
15+
# specific language governing permissions and limitations
16+
# under the License.
17+
18+
import uuid
19+
20+
from selenium.webdriver.remote.script_key import ScriptKey
21+
22+
23+
def test_script_key_equality():
24+
u = uuid.uuid4()
25+
key1 = ScriptKey(u)
26+
key2 = ScriptKey(u)
27+
key3 = ScriptKey(uuid.uuid4())
28+
29+
assert key1 == key2
30+
assert key1 == u
31+
assert key1 != key3
32+
assert key1 != "not-a-key"
33+
34+
35+
def test_script_key_hash():
36+
u = uuid.uuid4()
37+
key1 = ScriptKey(u)
38+
key2 = ScriptKey(u)
39+
key3 = ScriptKey(uuid.uuid4())
40+
41+
assert hash(key1) == hash(key2)
42+
assert hash(key1) == hash(u)
43+
assert hash(key1) != hash(key3)
44+
45+
key_set = {key1, key3}
46+
assert key2 in key_set
47+
48+
key_dict = {key1: "script_val"}
49+
assert key_dict[key2] == "script_val"
50+
51+
52+
def test_script_key_repr():
53+
key = ScriptKey("custom_id")
54+
assert repr(key) == "ScriptKey(id=custom_id)"

0 commit comments

Comments
 (0)