Skip to content

Commit e5933f2

Browse files
titusfortnertitusfortner
committed
[py] fix flaky test
1 parent a4a456a commit e5933f2

1 file changed

Lines changed: 16 additions & 5 deletions

File tree

‎py/test/selenium/webdriver/firefox/ff_installs_addons_tests.py‎

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import zipfile
2020

2121
from selenium.webdriver.common.by import By
22+
from selenium.webdriver.support.wait import WebDriverWait
2223

2324
extensions = os.path.abspath("../../../../../../test/extensions/")
2425

@@ -30,7 +31,9 @@ def test_install_uninstall_signed_addon_xpi(driver, pages):
3031
assert id == "[email protected]"
3132

3233
pages.load("blank.html")
33-
injected = driver.find_element(By.ID, "webextensions-selenium-example")
34+
injected = WebDriverWait(driver, timeout=2).until(
35+
lambda dr: dr.find_element(By.ID, "webextensions-selenium-example")
36+
)
3437
assert injected.text == "Content injected by webextensions-selenium-example"
3538

3639
driver.uninstall_addon(id)
@@ -45,7 +48,9 @@ def test_install_uninstall_signed_addon_zip(driver, pages):
4548
assert id == "[email protected]"
4649

4750
pages.load("blank.html")
48-
injected = driver.find_element(By.ID, "webextensions-selenium-example")
51+
injected = WebDriverWait(driver, timeout=2).until(
52+
lambda dr: dr.find_element(By.ID, "webextensions-selenium-example")
53+
)
4954
assert injected.text == "Content injected by webextensions-selenium-example"
5055

5156
driver.uninstall_addon(id)
@@ -60,7 +65,9 @@ def test_install_uninstall_unsigned_addon_zip(driver, pages):
6065
assert id == "[email protected]"
6166

6267
pages.load("blank.html")
63-
injected = driver.find_element(By.ID, "webextensions-selenium-example")
68+
injected = WebDriverWait(driver, timeout=2).until(
69+
lambda dr: dr.find_element(By.ID, "webextensions-selenium-example")
70+
)
6471
assert injected.text == "Content injected by webextensions-selenium-example"
6572

6673
driver.uninstall_addon(id)
@@ -79,7 +86,9 @@ def test_install_uninstall_signed_addon_dir(driver, pages):
7986
assert id == "[email protected]"
8087

8188
pages.load("blank.html")
82-
injected = driver.find_element(By.ID, "webextensions-selenium-example")
89+
injected = WebDriverWait(driver, timeout=2).until(
90+
lambda dr: dr.find_element(By.ID, "webextensions-selenium-example")
91+
)
8392
assert injected.text == "Content injected by webextensions-selenium-example"
8493

8594
driver.uninstall_addon(id)
@@ -97,7 +106,9 @@ def test_install_uninstall_unsigned_addon_dir(driver, pages):
97106
assert id == "[email protected]"
98107

99108
pages.load("blank.html")
100-
injected = driver.find_element(By.ID, "webextensions-selenium-example")
109+
injected = WebDriverWait(driver, timeout=2).until(
110+
lambda dr: dr.find_element(By.ID, "webextensions-selenium-example")
111+
)
101112
assert injected.text == "Content injected by webextensions-selenium-example"
102113

103114
driver.uninstall_addon(id)

0 commit comments

Comments
 (0)