Skip to content

Commit 7805592

Browse files
authored
Merge 8de73fe into 669a493
2 parents 669a493 + 8de73fe commit 7805592

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

.bazelrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ build --test_env=GITHUB_ACTIONS
5555
build --test_env=MOZ_HEADLESS
5656
build --test_env=PATH # Remove once browser pinning works
5757
build --test_env=SELENIUM_BROWSER
58-
build --test_env=SELENIUM_MANAGER_BASE_PATH
5958
build --test_env=TRAVIS
6059
build --test_env=PYTHON_VERSION
6160

.github/workflows/bazel.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ jobs:
5555
- name: Free space
5656
if: inputs.os != 'windows'
5757
run: ./scripts/github-actions/free-disk-space.sh
58+
- name: Remove driver directories
59+
if: inputs.os != 'windows'
60+
run: |
61+
sudo rm -rf $CHROMEWEBDRIVER $EDGEWEBDRIVER $GECKOWEBDRIVER
5862
- name: Set Ruby version
5963
if: inputs.ruby-version != ''
6064
run: echo 'RUBY_VERSION = "${{ inputs.ruby-version }}"' > rb/ruby_version.bzl

javascript/node/selenium-webdriver/BUILD.bazel

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@ jasmine_node_test(
9090
local = True,
9191
templated_args = ["--node_options=--require=$$(rlocation $(rootpath :tools/init_jasmine.js))"],
9292
deps = [
93+
":manager-linux",
94+
":manager-macos",
95+
":manager-windows",
9396
"//javascript/node/selenium-webdriver/lib/atoms:find-elements",
9497
"//javascript/node/selenium-webdriver/lib/atoms:get_attribute",
9598
"//javascript/node/selenium-webdriver/lib/atoms:is_displayed",

javascript/node/selenium-webdriver/common/seleniumManager.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,7 @@ function getBinary() {
4747
const file =
4848
directory === 'windows' ? 'selenium-manager.exe' : 'selenium-manager'
4949

50-
let seleniumManagerBasePath
51-
if (process.env.SELENIUM_MANAGER_BASE_PATH) {
52-
seleniumManagerBasePath = process.env.SELENIUM_MANAGER_BASE_PATH
53-
} else {
54-
seleniumManagerBasePath = path.join(__dirname, '..', '/bin')
55-
}
50+
let seleniumManagerBasePath = path.join(__dirname, '..', '/bin')
5651

5752
const filePath = path.join(seleniumManagerBasePath, directory, file)
5853

0 commit comments

Comments
 (0)