added onQuit handler for chromedriver

corevo · corevo · commit 4e62dd5f4567 · 2019-09-08T16:47:41.000+03:00
diff --git a/javascript/node/selenium-webdriver/chrome.js b/javascript/node/selenium-webdriver/chrome.js
@@ -687,12 +687,14 @@ class Driver extends webdriver.WebDriver {
    */
   static createSession(opt_config, opt_serviceExecutor) {
     let executor;
+    let onQuit;
     if (opt_serviceExecutor instanceof http.Executor) {
       executor = opt_serviceExecutor;
       configureExecutor(executor);
     } else {
       let service = opt_serviceExecutor || getDefaultService();
       executor = createExecutor(service.start());
+      onQuit = () => service.kill();
     }
 
     let caps = opt_config || Capabilities.chrome();
@@ -707,7 +709,7 @@ class Driver extends webdriver.WebDriver {
       }
     }
 
-    return /** @type {!Driver} */(super.createSession(executor, caps));
+    return /** @type {!Driver} */(super.createSession(executor, caps, onQuit));
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -687,12 +687,14 @@ class Driver extends webdriver.WebDriver {`
`687`	`687`	`*/`
`688`	`688`	`static createSession(opt_config, opt_serviceExecutor) {`
`689`	`689`	`let executor;`
	`690`	`+ let onQuit;`
`690`	`691`	`if (opt_serviceExecutor instanceof http.Executor) {`
`691`	`692`	`executor = opt_serviceExecutor;`
`692`	`693`	`configureExecutor(executor);`
`693`	`694`	`} else {`
`694`	`695`	`let service = opt_serviceExecutor \|\| getDefaultService();`
`695`	`696`	`executor = createExecutor(service.start());`
	`697`	`+ onQuit = () => service.kill();`
`696`	`698`	`}`
`697`	`699`
`698`	`700`	`let caps = opt_config \|\| Capabilities.chrome();`
`@@ -707,7 +709,7 @@ class Driver extends webdriver.WebDriver {`
`707`	`709`	`}`
`708`	`710`	`}`
`709`	`711`
`710`		`- return /** @type {!Driver} */(super.createSession(executor, caps));`
	`712`	`+ return /** @type {!Driver} */(super.createSession(executor, caps, onQuit));`
`711`	`713`	`}`
`712`	`714`
`713`	`715`	`/**`