[py] implement proxy support for Selenium Manager

titusfortner · titusfortner · commit 3dec0aec52d2 · 2023-05-25T15:44:11.000-05:00
diff --git a/py/selenium/webdriver/common/selenium_manager.py b/py/selenium/webdriver/common/selenium_manager.py
@@ -85,6 +85,12 @@ def driver_location(self, options: BaseOptions) -> str:
             args.append("--browser-path")
             args.append(str(binary_location))
 
+        proxy = options.proxy
+        if proxy and (proxy.http_proxy or proxy.ssl_proxy):
+            args.append("--proxy")
+            value = proxy.ssl_proxy if proxy.sslProxy else proxy.http_proxy
+            args.append(value)
+
         if logger.getEffectiveLevel() == logging.DEBUG:
             args.append("--debug")
 
diff --git a/py/test/selenium/webdriver/common/selenium_manager_tests.py b/py/test/selenium/webdriver/common/selenium_manager_tests.py
@@ -21,6 +21,7 @@
 
 from selenium.common.exceptions import SeleniumManagerException
 from selenium.webdriver.chrome.options import Options
+from selenium.webdriver.common.proxy import Proxy
 from selenium.webdriver.common.selenium_manager import SeleniumManager
 
 
@@ -62,6 +63,27 @@ def test_browser_path_is_used_for_sm(mocker):
     assert "/opt/bin/browser-bin" in args[0]
 
 
+def test_proxy_is_used_for_sm(mocker):
+    import subprocess
+
+    mock_run = mocker.patch("subprocess.run")
+    mocked_result = Mock()
+    mocked_result.configure_mock(
+        **{"stdout.decode.return_value": '{"result": {"message": "driver"}, "logs": []}', "returncode": 0}
+    )
+    mock_run.return_value = mocked_result
+    options = Options()
+    options.capabilities["browserName"] = "chrome"
+    proxy = Proxy()
+    proxy.http_proxy = "http-proxy"
+    options.proxy = proxy
+
+    _ = SeleniumManager().driver_location(options)
+    args, kwargs = subprocess.run.call_args
+    assert "--proxy" in args[0]
+    assert "http-proxy" in args[0]
+
+
 def test_stderr_is_propagated_to_exception_messages():
     msg = r"Selenium Manager failed for:.* --browser foo --output json\.\nInvalid browser name: foo\n"
     with pytest.raises(SeleniumManagerException, match=msg):
